PR: Address pylint's "consider-using-with" warnings#20
Merged
ccordoba12 merged 2 commits intopython-lsp:developfrom Apr 26, 2021
Merged
PR: Address pylint's "consider-using-with" warnings#20ccordoba12 merged 2 commits intopython-lsp:developfrom
ccordoba12 merged 2 commits intopython-lsp:developfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19 by adding context managers in all places flagged by
consider-using-with. ExitStack was added in places where the simplewithstatement cannot be used.